Skip to content

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 24, 2025

Proposed changes

Problem: We don't currently support the latest version of the Gateway API

Solution: Upgrade to v1.4.0, including BackendTLSPolicy promotion -> v1 and other Policy type promotion -> v1. See the full changelog. Also enables the conformance tests for BackendTLSPolicy.

This also requires upgrading the inference extension from 1.0.2 -> 1.1.0 to resolve dependency conflicts.

Testing: unit testing, running the pipeline for conformance and functional testing, but the RC run passed conformance.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4034
Closes #3795

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Upgrade Gateway API to v1.4.0

@ciarams87 ciarams87 requested a review from a team as a code owner October 24, 2025 15:30
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Oct 24, 2025
@ciarams87 ciarams87 force-pushed the feat/upgrade-gwapi-1.4.0 branch from e403a72 to 514c578 Compare October 24, 2025 15:40
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (5c78a60) to head (14054ba).

Files with missing lines Patch % Lines
internal/controller/state/conditions/conditions.go 0.00% 15 Missing ⚠️
internal/controller/state/graph/gatewayclass.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4166   +/-   ##
=======================================
  Coverage   85.99%   86.00%           
=======================================
  Files         131      131           
  Lines       14063    14058    -5     
  Branches       35       35           
=======================================
- Hits        12093    12090    -3     
+ Misses       1770     1766    -4     
- Partials      200      202    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR is also updating inference extension from 1.0.2 -> 1.1.0, which i guess is fine, but was that intentional? If so we should add that to the PR notes.

@ciarams87
Copy link
Contributor Author

Looks like this PR is also updating inference extension from 1.0.2 -> 1.1.0, which i guess is fine, but was that intentional? If so we should add that to the PR notes.

@bjee19 Good catch Ben - yes I needed to update this as well as there was a misnamed variable being referenced somewhere causing conformance tests to fail. I named the commit (Upgrade inference extension to v1.1.0 to fix conformance tests) but neglected to update the notes. Thank you!!

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


const (
// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.3.0/apis/v1/shared_types.go#L660
// Regex from: https://github.com/kubernetes-sigs/gateway-api/blob/v1.4.0/apis/v1/shared_types.go#L660
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciarams87 ciarams87 force-pushed the feat/upgrade-gwapi-1.4.0 branch from 00a8061 to 14054ba Compare October 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart release-notes

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

Upgrade to Gateway API v1.4.0 Support BackendTLSPolicy moving to standard channel

4 participants